Repository navigation
Described runs: pixel-type and dimension checks per unit (#239, narrowed) - #243
Merged
Merged
Conversation
In a described run the folder check's mixed_dtypes and inconsistent_dimensions no longer compare an RGB unit with a fluorescence unit: the notebook's folder check works inside each unit and the run compares units of one declared image_type. A mixed experiment now stops at R_HETEROGENEOUS_LAYOUT_NOT_ENABLED, which is not lifted. Undescribed runs are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
guijacquemet
marked this pull request as ready for review
November 9, 2026 07:01
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
A unit whose images disagree inside itself in arrangement or channel count is still refused by the described folder check, and units of one layout that disagree with each other in arrangement, channel count or axes are still refused by the run (inconsistent_mapping, R_CHANNEL_COUNT_MISMATCH, missing_axes). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239
Scope, narrowed by the owner on 2026-11-09. The Spec's refusal of RGB and non-RGB units in one description in Stages 1-2 (
R_HETEROGENEOUS_LAYOUT_NOT_ENABLED, experiment-v1 4.4b and 8, fixture v29) is not lifted. This PR only changes which refusal the user meets.What changes, in a described run only:
mixed_dtypesandinconsistent_dimensions(andmissing_axes,different_channel_counts,channel_names_differ, which the description replaces too) no longer compare an RGB unit with a fluorescence one.unit_consistency.unit_checked): the checks run inside each unit, because image types are not declared yet.check_description/declared_type_issues): pixel types are compared among units that declare the sameimage_type; the arrangement of dimensions stays with the axis review.R_HETEROGENEOUS_LAYOUT_NOT_ENABLED, explained in words on the check-and-save screen (existing text, now tested).checkand the non-described notebook are unchanged.Refactor: the dtype and arrangement checks move from
metadata.pytoimage_consistency.pyunchanged (metadata.py700 to 649 lines, baseline lowered).Tests:
tests/test_described_unit_checks.py(the existing P04 test is kept).Generated by Claude Code